This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
ci: more thorough link checking #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2020
Merged
dholbach
force-pushed
the
improve-link-checking
branch
2 times, most recently
from
dc94541 to
51fafcd
Compare
dholbach
pushed a commit
to fluxcd/helm-operator
that referenced
this pull request
Apr 1, 2020
dholbach
pushed a commit
to fluxcd/helm-operator
that referenced
this pull request
Apr 1, 2020
hiddeco
reviewed
Apr 1, 2020
hiddeco
approved these changes
Apr 2, 2020
- .github/workflows/markdown-link-check-config.json has some patterns we exlude while checking the markdown files in the top-level directories (company websites on README.md and billions of GH issues in CHANGELOG.md in particular) - once gaurav-nelson/github-action-markdown-link-check#26 is merged, we can move back to the official GH Action
dholbach
force-pushed
the
improve-link-checking
branch
from
22e0ee4 to
ab279ad
Compare
stefanprodan
changed the title
dholbach
pushed a commit
to fluxcd/helm-operator
that referenced
this pull request
Apr 3, 2020
dholbach
pushed a commit
to fluxcd/helm-operator
that referenced
this pull request
Apr 6, 2020
dholbach
pushed a commit
to fluxcd/helm-operator
that referenced
this pull request
Apr 7, 2020
dholbach
pushed a commit
to fluxcd/helm-operator
that referenced
this pull request
Apr 11, 2020
dholbach
pushed a commit
to fluxcd/helm-operator
that referenced
this pull request
Apr 27, 2020
dholbach
pushed a commit
to fluxcd/helm-operator
that referenced
this pull request
Apr 28, 2020
move back to upstream GH action update pymdown-extensions update to mkdocs-material 5: https://squidfunk.github.io/mkdocs-material/releases/5/#how-to-upgrade fix links follow fluxcd/flux#3006 parallelise checking
dholbach
pushed a commit
to fluxcd/helm-operator
that referenced
this pull request
Apr 29, 2020
move back to upstream GH action update pymdown-extensions update to mkdocs-material 5: https://squidfunk.github.io/mkdocs-material/releases/5/#how-to-upgrade fix links follow fluxcd/flux#3006 parallelise checking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split this out of #2948. So this PR can be about link checking only.
Overall it gets more complicated. What I'm doing here is:
siteusing the action which usesliche- this works as well as it did before./and./internal/docs- unfortunately you can't pass two paths easily and I needed to mess with thefindincantation in the action itself, thanks @hiddeco for the psychological support.