-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make flux pull
work for OCI artifacts produced by other tools
#4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@stefanprodan @hiddeco this change works for my own test case, I do wonder if we need a tag in pkg repo and if there is anything else to take care of here? |
stefanprodan
changed the title
Pull any artifact
Make Oct 5, 2023
flux pull
work for OCI artifacts produced by other tools
stefanprodan
added
area/oci
OCI related issues and pull requests
area/ux
In pursuit of a delightful user experience
labels
Oct 5, 2023
stefanprodan
force-pushed
the
pull-any-artifact
branch
from
October 12, 2023 12:55
07ce08b
to
5114b99
Compare
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
stefanprodan
force-pushed
the
pull-any-artifact
branch
from
October 12, 2023 13:01
5114b99
to
b46e298
Compare
stefanprodan
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stefanprodan
added
the
backport:release/v2.1.x
To be backported to release/v2.1.x
label
Oct 12, 2023
Successfully created backport PR for |
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Oct 13, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [fluxcd/flux2](https://github.com/fluxcd/flux2) | Kustomization | patch | `v2.1.1` -> `v2.1.2` | --- > ⚠ **Warning** > > Some dependencies could not be looked up. Check the warning logs for more information. --- ### Release Notes <details> <summary>fluxcd/flux2 (fluxcd/flux2)</summary> ### [`v2.1.2`](https://github.com/fluxcd/flux2/releases/tag/v2.1.2) [Compare Source](fluxcd/flux2@v2.1.1...v2.1.2) #### Highlights Flux `v2.1.2` is a patch release which comes with various fixes. Users are encouraged to upgrade for the best experience. ##### Fixes - Ensures faster recovery of `Kustomization` and `HelmRelease` resources when the source-controller has restarted and is working on restoring the storage. - Prevent source-controller from failing to reconcile `OCIRepositories` when artifacts contain symlinks. - Addresses issue with helm-controller miss-labeling Custom Resource Definitions. - Detect immutable field errors in Google Cloud resources managed by Flux `Kustomizations`. - Better error reporting for `flux bootstrap` when the owner doesn't match the identity associated with the given token. - Allow `flux pull artifact` to fetch OCI artifacts produced by other tools. #### Components changelog - source-controller [v1.1.2](https://github.com/fluxcd/source-controller/blob/v1.1.2/CHANGELOG.md) - kustomize-controller [v1.1.1](https://github.com/fluxcd/kustomize-controller/blob/v1.1.1/CHANGELOG.md) - helm-controller [v0.36.2](https://github.com/fluxcd/helm-controller/blob/v0.36.2/CHANGELOG.md) #### CLI Changelog - PR [#​4324](fluxcd/flux2#4324) - [@​somtochiama](https://github.com/somtochiama) - bootstrap: Fix error msg when the Git token doesn't match the repo owner - PR [#​4323](fluxcd/flux2#4323) - [@​stefanprodan](https://github.com/stefanprodan) - e2e: Update Go dependencies - PR [#​4313](fluxcd/flux2#4313) - [@​fluxcdbot](https://github.com/fluxcdbot) - Update toolkit components - PR [#​4296](fluxcd/flux2#4296) - [@​Skarlso](https://github.com/Skarlso) - fix: only wait for changeset if the result is not empty - PR [#​4285](fluxcd/flux2#4285) - [@​matheuscscp](https://github.com/matheuscscp) - Add badge for SLSA Level 3 - PR [#​4284](fluxcd/flux2#4284) - [@​errordeveloper](https://github.com/errordeveloper) - Make `flux pull` work for OCI artifacts produced by other tools </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMy4wIiwidXBkYXRlZEluVmVyIjoiMzcuMTMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/143 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/oci
OCI related issues and pull requests
area/ux
In pursuit of a delightful user experience
backport:release/v2.1.x
To be backported to release/v2.1.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
flux pull artifact
to retrieve any kind of OCI artifact without an index, e.g. a Helm chart for debugging.This is a follow-up to fluxcd/pkg#653