oci/client: pull any artifact #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
force-pushed
the
pull-any-artifact
branch
from
feb567e to
3818f0e
Compare
errordeveloper
force-pushed
the
pull-any-artifact
branch
2 times, most recently
from
b70d673 to
9018b11
Compare
errordeveloper
force-pushed
the
pull-any-artifact
branch
from
9018b11 to
7b5a7f2
Compare
errordeveloper
force-pushed
the
pull-any-artifact
branch
2 times, most recently
from
e8e8ee9 to
ff2d0b6
Compare
|
@stefanprodan I added a simple test, PTAL :) |
errordeveloper
force-pushed
the
pull-any-artifact
branch
from
ff2d0b6 to
6629b78
Compare
This is in order to allow `flux pull artifact` to retrieve any kind of OCI artifact, e.g. a Helm chart for debugging. Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
In OCI terms having platform `flux/flux/v2` implies that the image is runnable on some OS called "flux" on architecture called "flux". In reality there is no such platform and there is no good reason for Flux to pretend. OCI 1.1 (albeit still and RC at the moment), doesn't mandate artifact to define a platform at all. When client is constructed with a platform selector, many functions will apply the selector, which is often undesirable. The `flux/flux/v2` platform was only defined in client options, so it wasn't set on any images and is safe to drop; source-controller doesn't use `DefaultOptions`, so there is no concern. Another inconvenient behaviour of GGCR is that some functions will pick just the very first element that matches the platform and ignore any additional elements, e.g. elements with same platform, but different media type. That behaviour prevents searching for artefacts by media type. Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
errordeveloper
force-pushed
the
pull-any-artifact
branch
from
6629b78 to
887bad4
Compare
hiddeco
approved these changes
Sep 27, 2023
stefanprodan
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
flux pull artifactto retrieve any kind of OCI artifact without an index, e.g. a Helm chart for debugging.