Merge pull request #223 from fluxcd/reject-git-source

Reject git source if URL and path are missing

pkg/chartsync/git.go

@@ -68,22 +68,25 @@ func (c sourceRef) forHelmRelease(hr *v1.HelmRelease) bool {
 	if hr == nil || hr.Spec.GitChartSource == nil {
 		return false
 	}
+
+	// reject git source if URL and path are missing
+	if hr.Spec.GitURL == "" || hr.Spec.Path == "" {
+		return false
+	}
+
 	return c.mirror == mirrorName(hr) && c.remote == hr.Spec.GitURL && c.ref == hr.Spec.Ref
 }
 
 func NewGitChartSync(logger log.Logger,
 	lister lister.HelmReleaseLister, cfg GitConfig, queue ReleaseQueue) *GitChartSync {
 
 	return &GitChartSync{
-		logger: logger,
-		config: cfg,
-
-		lister: lister,
-
+		logger:             logger,
+		config:             cfg,
+		lister:             lister,
 		mirrors:            git.NewMirrors(),
 		releaseSourcesByID: make(map[string]sourceRef),
-
-		releaseQueue: queue,
+		releaseQueue:       queue,
 	}
 }
 

pkg/release/release.go

@@ -95,7 +95,7 @@ func (r *Release) Sync(client helm.Client, hr *v1.HelmRelease) (rHr *v1.HelmRele
 	// to the chart, and record the revision.
 	var chartPath, revision string
 	switch {
-	case hr.Spec.GitChartSource != nil:
+	case hr.Spec.GitChartSource != nil && hr.Spec.GitURL != "" && hr.Spec.Path != "":
 		var export *git.Export
 		var err error