Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Reject git source if URL and path are missing #223

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Reject git source if URL and path are missing #223

merged 1 commit into from
Jan 20, 2020

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Jan 20, 2020 •
edited
Loading

Helm operator choses to use a Git source when a chart comes from a Helm repository if ref is specified. This PR fixes the Git source detection by validating the git URL and path.

HR release spec that is mistaken for a Git source:

spec:
  chart:
    name: expressjs-k8s
    ref: master
    repository: https://alexellis.github.io/expressjs-k8s/
    version: 0.1.1

@stefanprodan stefanprodan requested a review from hiddeco January 20, 2020 16:16
hiddeco
hiddeco approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan stefanprodan merged commit ddd8ed7 into master Jan 20, 2020
@stefanprodan stefanprodan deleted the reject-git-source branch January 20, 2020 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @hiddeco