Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure/ACR "autologin" #180

Closed
squaremo opened this issue Oct 14, 2021 · 0 comments · Fixed by #194
Closed

Azure/ACR "autologin" #180

squaremo opened this issue Oct 14, 2021 · 0 comments · Fixed by #194
Labels
enhancement New feature or request

Comments

@squaremo
Copy link
Member

squaremo commented Oct 14, 2021

#174 adds a flag to the controller that lets it use the AWS client to get credentials for ECR; the argument is that if you're running in EKS (and possibly elsewhere in AWS), all pods will by default have read access to your account in ECR, so you gain a lot in convenience without giving anything away by assuming all ImageRepository objects should have access to your ECR account too.

A similar situation exists in Azure (or AKS) with ACR, so it may be similarly convenient (and justifiable) to use a platform-specific client or mechanism to get credentials for images in ACR.

Related: #11

@squaremo squaremo added the enhancement New feature or request label Oct 14, 2021
kingdonb pushed a commit to kingdonb/image-reflector-controller that referenced this issue Oct 31, 2021
kingdonb pushed a commit to kingdonb/image-reflector-controller that referenced this issue Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant