-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure/ACR "autologin" #180
Labels
enhancement
New feature or request
Comments
4 tasks
lloydchang
added a commit
to lloydchang/image-reflector-controller
that referenced
this issue
Oct 31, 2021
…d): elaborate on how to enable autologin for ECR fluxcd/flux#1619 fluxcd/flux2#107 fluxcd#11 fluxcd#139 fluxcd#147 fluxcd#174 fluxcd#179 fluxcd#180 fluxcd/website#601 fluxcd#193 fluxcd/website#611 https://fluxcd.io/docs/guides/image-update/#aws-elastic-container-registry Signed-off-by: lloydchang <lloydchang@gmail.com>
kingdonb
pushed a commit
to lloydchang/image-reflector-controller
that referenced
this issue
Oct 31, 2021
…d): elaborate on how to enable autologin for ECR fluxcd/flux#1619 fluxcd/flux2#107 fluxcd#11 fluxcd#139 fluxcd#147 fluxcd#174 fluxcd#179 fluxcd#180 fluxcd/website#601 fluxcd#193 fluxcd/website#611 https://fluxcd.io/docs/guides/image-update/#aws-elastic-container-registry Signed-off-by: lloydchang <lloydchang@gmail.com>
kingdonb
pushed a commit
to kingdonb/image-reflector-controller
that referenced
this issue
Oct 31, 2021
…d): elaborate on how to enable autologin for ECR fluxcd/flux#1619 fluxcd/flux2#107 fluxcd#11 fluxcd#139 fluxcd#147 fluxcd#174 fluxcd#179 fluxcd#180 fluxcd/website#601 fluxcd#193 fluxcd/website#611 https://fluxcd.io/docs/guides/image-update/#aws-elastic-container-registry Signed-off-by: lloydchang <lloydchang@gmail.com> Signed-off-by: Kingdon Barrett <kingdon@weave.works>
kingdonb
pushed a commit
to kingdonb/image-reflector-controller
that referenced
this issue
Dec 16, 2021
…d): elaborate on how to enable autologin for ECR fluxcd/flux#1619 fluxcd/flux2#107 fluxcd#11 fluxcd#139 fluxcd#147 fluxcd#174 fluxcd#179 fluxcd#180 fluxcd/website#601 fluxcd#193 fluxcd/website#611 https://fluxcd.io/docs/guides/image-update/#aws-elastic-container-registry Signed-off-by: lloydchang <lloydchang@gmail.com> Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#174 adds a flag to the controller that lets it use the AWS client to get credentials for ECR; the argument is that if you're running in EKS (and possibly elsewhere in AWS), all pods will by default have read access to your account in ECR, so you gain a lot in convenience without giving anything away by assuming all
ImageRepository
objects should have access to your ECR account too.A similar situation exists in Azure (or AKS) with ACR, so it may be similarly convenient (and justifiable) to use a platform-specific client or mechanism to get credentials for images in ACR.
Related: #11
The text was updated successfully, but these errors were encountered: