Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(image-reflector-controller/docs/spec/v1beta1/imagerepositories.md): elaborate on how to enable autologin for ECR #1

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

@lloydchang
Copy link
Author

• Inline directly relevant quotes so that people don’t have to click through the links just to better understand the prerequisite
• Link many related in one place (Git commit and PR description) for broader context
• Fix a few grammar and typo issues in other parts of document

Thank you @kingdonb

@kingdonb kingdonb changed the base branch from main to explain-autologin-for-ecr October 31, 2021 19:16
@kingdonb
Copy link
Owner

Thanks for the review and the additions. I rebased this on my own PR branch, in order to be sure the example patch and the clarifying statement that explicitly mentions image-reflector-controller are both still included.

I also felt like there were too many redundant links in your patch, so I removed most of them. I think I have still included all of the important references that you meant to add.

I'll include these in my PR, thanks again @lloydchang ! 🎉

@kingdonb kingdonb merged commit e34d8b7 into kingdonb:explain-autologin-for-ecr Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants