Add various instructions on development documentation #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Huang <tom.huang@weave.works>
tomhuang12
force-pushed
the
development-doc
branch
from
1a6db3f
to
b60be50
Compare
relu
requested changes
Nov 2, 2021
There was a problem hiding this comment.
Great work, @tomhuang12! 🙌
I left a few comments, hope it helps.
Signed-off-by: Tom Huang <tom.huang@weave.works>
|
@relu Thanks for the review. Please see updated changes. |
relu
reviewed
Nov 3, 2021
Signed-off-by: Tom Huang <tom.huang@weave.works>
|
Can you rebase your PR? |
|
It is rebased now. Thanks |
kingdonb
suggested changes
Jan 5, 2022
There was a problem hiding this comment.
LGTM 👍 but the rebase is a bit off
@tomhuang12 Your PR is still based off of: 2d05314 while head is currently: 62c06ea
I think you need to fast-forward advance your local main branch before rebasing, could you take another look at this?
(I do not have triage here, nor write access, so my review does not count)
Cross-namespace ImageRepository resources should trigger reconciles for ImagePolicies that refer to them. Previously, this was only done for resources in the same namespace. Fixes fluxcd#195 Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
The imageRepoKey only contains the name of the ImageRepository resource. This change uses the namespaced name to avoid collisions. Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Fixes a regression introduced in v0.13.1 Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Pawel Rozlach <vespian@users.noreply.github.com>
- Update `github.com/aws/aws-sdk-go` to `v1.42.9` - Update `github.com/dgraph-io/badger/v3` to `v3.2103.2` - Update `github.com/google/go-containerregistry` to `v0.7.0` - Update `k8s.io/*` to `v0.22.2` - Update `sigs.k8s.io/controller-runtime` to `v0.10.2` Signed-off-by: Hidde Beydals <hello@hidde.co>
Fix CVE-2021-41190 warning. Signed-off-by: Hidde Beydals <hello@hidde.co>
This ensures tools like `kstatus` do not consider the resource to be in a `Ready` state premataturely due to `generation` and `observedGeneration` equaling to `0` for a short period of time. Signed-off-by: Tom Huang <tom.huang@weave.works>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Adds a descriptive error when an invalid image ref containing a scheme is given to the ImageRepository. Fixes fluxcd#146 Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
|
I messed up the rebase. I am going to open another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #182.