libgit2: Disable connection caching #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test images based on version 830771f:
UPDATE: changed IAC image to v0.22.2-cacheless |
This was referenced May 6, 2022
pjbgf
force-pushed
the
libgit2-cacheless-conns
branch
2 times, most recently
from
1df3236
to
6d51758
Compare
|
New image for source controller based on 6d51758: UPDATE: replace image with official release candidate version. |
pjbgf
force-pushed
the
libgit2-cacheless-conns
branch
from
6d51758
to
1266bea
Compare
|
Removed "enable managed transport" commit from this PR, we shall treat it as a separate PR. |
hiddeco
reviewed
May 13, 2022
pjbgf
force-pushed
the
libgit2-cacheless-conns
branch
from
1266bea
to
7bcd2ee
Compare
aryan9600
reviewed
May 13, 2022
Connection caching was a feature created to resolve upstream issues raised from concurrent ssh connections. Some scenarios were based on multiple key exchange operations happening at the same time. This PR removes the connection caching, and instead: - Services Session.StdoutPipe() as soon as possible, as it is a known source of blocking SSH connections. - Reuse SSH connection within the same subtransport, eliminating the need for new handshakes when talking with the same server. - Simplifies the entire transport logic for better maintainability. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
pjbgf
force-pushed
the
libgit2-cacheless-conns
branch
from
7bcd2ee
to
ce92881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection caching was a feature created to resolve upstream issues raised from concurrent ssh connections.
Some scenarios were based on multiple key exchange operations happening at the same time.
This PR removes the connection caching, and instead:
Session.StdoutPipe()as soon as possible, as it is a known source of blocking SSH connections.with the same server.
This also fixes the panic below when connecting to AWS CodeCommit with Managed Transport.
Note that this logic is not captured by the panic recovery due to its execution path not starting from the Checkout func.
Additional changes are being made to completely remove the dependency to
SmartCertificateCheck, which will ensure this does not happen at all going forwards. But that will be dealt with in subsequent PRs.