fix: Use deterministic execution names in scheduler #5724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@apache.org>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5724 +/- ##
=======================================
Coverage 36.19% 36.20%
=======================================
Files 1303 1303
Lines 109554 109560 +6
=======================================
+ Hits 39657 39669 +12
+ Misses 65778 65771 -7
- Partials 4119 4120 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
pmahindrakar-oss
approved these changes
Sep 5, 2024
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 9, 2024
* feat: Use deterministic execution names in scheduler Signed-off-by: Kevin Su <pingsutw@apache.org> * fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 9, 2024
* feat: Use deterministic execution names in scheduler Signed-off-by: Kevin Su <pingsutw@apache.org> * fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
bgedik
pushed a commit
to bgedik/flyte
that referenced
this pull request
Sep 12, 2024
* feat: Use deterministic execution names in scheduler Signed-off-by: Kevin Su <pingsutw@apache.org> * fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Signed-off-by: Bugra Gedik <bgedik@gmail.com>
eapolinario
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Revert "fix: Use deterministic execution names in scheduler (#5724)" This reverts commit a058fd1. * Revert "Improve execution name readability (#5637)" This reverts commit 2ed2408. * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * make helm Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
https://github.com/flyteorg/flyte/pull/5637/files changes the execution name to a random string in the scheduler, but it should use a deterministic name. Otherwise, the scheduler will create multiple executions for the same time slot.
What changes were proposed in this pull request?
generate a deterministic hash and than use it to generate a human id
How was this patch tested?
unit test
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA