Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Archived workflows #672

Closed
wants to merge 5 commits into from
Closed

Include Archived workflows #672

wants to merge 5 commits into from

Conversation

james-union
Copy link
Contributor

@james-union james-union commented Jan 19, 2023

(flyteorg/flyte#3433)

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Sending [Archived, NonArchived] state with VALUE_IN filter operation to get all executions/tasks

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

flyteorg/flyte#661

@james-union james-union changed the base branch from devmain to master January 19, 2023 17:16
@james-union james-union self-assigned this Jan 19, 2023
@ursucarina
Copy link
Contributor

@james-union can you please target master?

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #672 (63e24f5) into master (ffb161c) will decrease coverage by 0.17%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   66.95%   66.79%   -0.17%     
==========================================
  Files         455      456       +1     
  Lines       11280    11291      +11     
  Branches     2077     2076       -1     
==========================================
- Hits         7553     7542      -11     
- Misses       3727     3749      +22     
Impacted Files Coverage Δ
...orkflow/filters/useWorkflowIncludeArchivedState.ts 0.00% <0.00%> (ø)
...nsole/src/components/Entities/EntityExecutions.tsx 93.75% <ø> (ø)
...ole/src/components/Executions/ExecutionFilters.tsx 77.55% <ø> (ø)
...onsole/src/components/Project/ProjectDashboard.tsx 96.15% <ø> (ø)
...es/console/src/components/Project/ProjectTasks.tsx 100.00% <ø> (ø)
...ole/src/components/Task/SearchableTaskNameList.tsx 84.69% <ø> (ø)
...rc/components/common/FilterableNamedEntityList.tsx 94.11% <ø> (ø)
...nts/Executions/filters/useExecutionArchiveState.ts 90.00% <100.00%> (ø)
...onsole/src/components/Project/ProjectWorkflows.tsx 100.00% <100.00%> (ø)
...le/src/components/Task/useTaskShowArchivedState.ts 100.00% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@james-union
Copy link
Contributor Author

@ursucarina I've rebased with master

Signed-off-by: James <james@union.ai>
Signed-off-by: James <james@union.ai>
Signed-off-by: James <james@union.ai>
Signed-off-by: James <james@union.ai>
Signed-off-by: James <james@union.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants