Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REJECT support for ApprovedCondition for GateNodes #733

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

james-union
Copy link
Contributor

Adding a Reject button for ApprovedCondition of GateNodes

image

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added a new state SELECT_REJECT to be true or false. When it's going to be reject, it should be true before SUBMIT

Tracking Issue

fixes flyteorg/flyte#3346

Signed-off-by: James <james@union.ai>
Signed-off-by: James <james@union.ai>
@james-union james-union self-assigned this Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #733 (38512c8) into master (6816a5f) will decrease coverage by 0.14%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
- Coverage   66.74%   66.61%   -0.14%     
==========================================
  Files         464      464              
  Lines       11356    11370      +14     
  Branches     2086     2094       +8     
==========================================
- Hits         7580     7574       -6     
- Misses       3776     3796      +20     
Impacted Files Coverage Δ
...onsole/src/components/Launch/LaunchForm/strings.ts 100.00% <ø> (ø)
...components/Launch/LaunchForm/LaunchFormActions.tsx 79.16% <44.44%> (-10.58%) ⬇️
.../components/Launch/LaunchForm/ResumeSignalForm.tsx 94.28% <50.00%> (-5.72%) ⬇️
...components/Launch/LaunchForm/useResumeFormState.ts 86.36% <50.00%> (ø)
.../src/components/Launch/LaunchForm/launchMachine.ts 89.09% <100.00%> (+0.20%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jsonporter jsonporter merged commit 6ebd69f into master Mar 28, 2023
@jsonporter jsonporter deleted the james/gate-node-reject branch March 28, 2023 02:14
4nalog pushed a commit that referenced this pull request Mar 30, 2023
* fix: approveCondition reject

Signed-off-by: James <james@union.ai>

* fix: approve button

Signed-off-by: James <james@union.ai>

---------

Signed-off-by: James <james@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>
jsonporter added a commit that referenced this pull request Mar 30, 2023
* fix: type error on invalid nested json input

Signed-off-by: 4nalog <4nalog@protonmail.com>

* LaunchForm RJSF Form issue (#692)

* fix: launchform

Signed-off-by: James <james@union.ai>

* fix: stuck issue

Signed-off-by: James <james@union.ai>

* fix: on form change

Signed-off-by: James <james@union.ai>

* fix: merge master into branch

Signed-off-by: James <james@union.ai>

---------

Signed-off-by: James <james@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: bump minor version

Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: package version to 1.4.2 (#700)

Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: project settings dashbboard tests (#701)

* fix: project settings dashbboard tests

Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: remove .only

Signed-off-by: 4nalog <4nalog@protonmail.com>

* refactor: remove empty waitFor

Signed-off-by: 4nalog <4nalog@protonmail.com>

---------

Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: upgrading node version to 18 (#703)

Upgrading node version to 18

Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: revert node version (#704)

* fix: revert node version

Signed-off-by: Carina Ursu <carina@union.ai>

* Revert "fix: upgrading node version to 18 (#703)"

This reverts commit e5f9a8b.

Signed-off-by: Carina Ursu <carina@union.ai>

---------

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: deployment optimization (#706)

* fix: deployment optimization

Signed-off-by: Carina Ursu <carina@union.ai>

* clean up node modules and one file that we think is not needed

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

---------

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* fix: upgrade release node version (#707)

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: update chalk, add semantic-release test cmd (#708)

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: implement logic to handle multiple keys for nested data classes

Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: fix update_npmversion (#709)

* chore: fix update_npmversion

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: edits

Signed-off-by: Carina Ursu <carina@union.ai>

---------

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* Mapped Tasks not showing cache status correctly. (#712)

* fix: cache status logs indexing mismatch and react rendering cycle issue

Signed-off-by: James <james@union.ai>

* fix: mapped task cache status

Signed-off-by: James <james@union.ai>

---------

Signed-off-by: James <james@union.ai>
Co-authored-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: cleanup, passthrough runtime variables (#710)

fix: passthrough runtime variables

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: update_npmversion (#713)

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: fix sed makefile error (#714)

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* FE: Update flyteconsole to Node 18 (#717)

fix: nodejs 18 upgrade

Signed-off-by: James <james@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: allow complex workflow names (#715)

* chore: allow complex workflow names

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: fix buold:watch

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: yarn.lock

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: upgrade package

Signed-off-by: Carina Ursu <carina@union.ai>

---------

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: show correct app version in info  (#716)

* chore: show correct app version in info

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: update ver

Signed-off-by: Carina Ursu <carina@union.ai>

---------

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: left nav doesn't accurately update on  workflow version page (#718)

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* feat: differentiate between cache disabled and cache put failure (#719)

fix: add icon for put failure

Signed-off-by: James <james@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: fix formatting

Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: add material-ui class name seed (#721)

* chore: add material-ui class name seed

Signed-off-by: Carina Ursu <carina@union.ai>

* fix: overflow of modal

Signed-off-by: James <james@union.ai>

---------

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: James <james@union.ai>
Co-authored-by: James <james@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* The rendering of node status in a dynamic workflow is not functioning correctly (#723)

fix: dynamic nodes status

Signed-off-by: James <james@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: backfill index on execution task logs (#725)

* chore: backfill index on execution task logs

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: add comments

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: bump version

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: remove backfill

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: lint

Signed-off-by: Carina Ursu <carina@union.ai>

---------

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: release fail (#726)

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* Install deps directly in checks.yml (#728)

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: eduardo apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: show correct i/o in details panel  (#727)

* chore: show correct i/o in details panel

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: bump version

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: feedback

Signed-off-by: Carina Ursu <carina@union.ai>

---------

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: task observability (#720)

* chore: tlro basic setup

Signed-off-by: Carina Ursu <carina@union.ai>

* progress checkin

* Stable state refactored to use generic naming

* updated types

* working before updating routes

* chore: progress

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: remove debugger

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: allow custom class in execution actions

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: lint fix

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: bump console

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: up package version

Signed-off-by: Carina Ursu <carina@union.ai>

---------

Signed-off-by: Carina Ursu <carina@union.ai>
Co-authored-by: Jason Porter <jason@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: fix contextual menu action buttons color (#730)

* chore: fix contextual menu action buttons color

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: up console version

Signed-off-by: Carina Ursu <carina@union.ai>

---------

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: add build:watch to all packages (#731)

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* Add REJECT support for ApprovedCondition for GateNodes (#733)

* fix: approveCondition reject

Signed-off-by: James <james@union.ai>

* fix: approve button

Signed-off-by: James <james@union.ai>

---------

Signed-off-by: James <james@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* gate node in dynamic task (#729)

* fix: gate node in dynamic

Signed-off-by: James <james@union.ai>

* fix: upgraded version

Signed-off-by: James <james@union.ai>

* fix: compiledNode in PausedTasksComponent and ExecutionDetailsActions

Signed-off-by: James <james@union.ai>

* fix: upgrade version

Signed-off-by: James <james@union.ai>

* chore: lockfile

Signed-off-by: Carina Ursu <carina@union.ai>

* fix: remove caching for workflow closure

Signed-off-by: James <james@union.ai>

* fix: break link between cache and context state

Signed-off-by: James <james@union.ai>

---------

Signed-off-by: James <james@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Co-authored-by: Carina Ursu <carina@union.ai>
Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: comments

Signed-off-by: 4nalog <4nalog@protonmail.com>

---------

Signed-off-by: 4nalog <4nalog@protonmail.com>
Signed-off-by: James <james@union.ai>
Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: james-union <105876962+james-union@users.noreply.github.com>
Co-authored-by: Jason Porter <84735036+jsonporter@users.noreply.github.com>
Co-authored-by: Carina Ursu <carina@union.ai>
Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Co-authored-by: James <james@union.ai>
Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
Co-authored-by: eduardo apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Jason Porter <jason@union.ai>
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.5.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI Feature] Add support for ApprovedCondition for GateNodes
3 participants