Update default config to work out-of-the-box with flytectl demo

flytekit/configuration/__init__.py

@@ -300,7 +300,7 @@ class PlatformConfig(object):
     :param endpoint: DNS for Flyte backend
     :param insecure: Whether or not to use SSL
     :param insecure_skip_verify: Wether to skip SSL certificate verification
-    :param console_endpoint: endpoint for console if differenet than Flyte backend
+    :param console_endpoint: endpoint for console if different than Flyte backend
     :param command: This command is executed to return a token using an external process.
     :param client_id: This is the public identifier for the app which handles authorization for a Flyte deployment.
       More details here: https://www.oauth.com/oauth2-servers/client-registration/client-id-secret/.
@@ -311,8 +311,8 @@ class PlatformConfig(object):
     :param auth_mode: The OAuth mode to use. Defaults to pkce flow.
     """
 
-    endpoint: str = "localhost:30081"
-    insecure: bool = False
+    endpoint: str = "localhost:30080"
+    insecure: bool = True
     insecure_skip_verify: bool = False
     console_endpoint: typing.Optional[str] = None
     command: typing.Optional[typing.List[str]] = None
@@ -558,7 +558,7 @@ def for_sandbox(cls) -> Config:
         :return: Config
         """
         return Config(
-            platform=PlatformConfig(endpoint="localhost:30081", auth_mode="Pkce", insecure=True),
+            platform=PlatformConfig(endpoint="localhost:30080", auth_mode="Pkce", insecure=True),
             data_config=DataConfig(
                 s3=S3Config(endpoint="http://localhost:30084", access_key_id="minio", secret_access_key="miniostorage")
             ),

flytekit/configuration/file.py

@@ -18,6 +18,11 @@
 FLYTECTL_CONFIG_ENV_VAR = "FLYTECTL_CONFIG"
 
 
+def _exists(v: typing.Any) -> bool:
+    """Check if a value is defined."""
+    return isinstance(v, bool) or (v is not None and v)
+
+
 @dataclass
 class LegacyConfigEntry(object):
     """
@@ -54,7 +59,8 @@ def read_from_file(
             return None
         try:
             v = cfg.get(self)
-            return transform(v) if transform else v
+            if _exists(v):
+                return transform(v) if transform else v
         except configparser.Error:
             pass
         return None
@@ -63,7 +69,7 @@ def read_from_file(
 @dataclass
 class YamlConfigEntry(object):
     """
-    Creates a record for the config entry. contains
+    Creates a record for the config entry.
     Args:
         switch: dot-delimited string that should match flytectl args. Leaving it as dot-delimited instead of a list
           of strings because it's easier to maintain alignment with flytectl.
@@ -80,10 +86,11 @@ def read_from_file(
             return None
         try:
             v = cfg.get(self)
-            if v:
+            if _exists(v):
                 return transform(v) if transform else v
         except Exception:
             ...
+
         return None
 
 
@@ -224,7 +231,7 @@ def legacy_config(self) -> _configparser.ConfigParser:
         return self._legacy_config
 
     @property
-    def yaml_config(self) -> typing.Dict[str, Any]:
+    def yaml_config(self) -> typing.Dict[str, typing.Any]:
         return self._yaml_config
 
 
@@ -273,7 +280,7 @@ def set_if_exists(d: dict, k: str, v: typing.Any) -> dict:
 
         The input dictionary ``d`` will be mutated.
     """
-    if v:
+    if _exists(v):
         d[k] = v
     return d
 

tests/flytekit/unit/remote/test_remote.py

@@ -231,7 +231,7 @@ def test_generate_console_http_domain_sandbox_rewrite(mock_client):
         remote = FlyteRemote(
             config=Config.auto(config_file=temp_filename), default_project="project", default_domain="domain"
         )
-        assert remote.generate_console_http_domain() == "http://localhost:30080"
+        assert remote.generate_console_http_domain() == "http://localhost:30081"
 
         with open(temp_filename, "w") as f:
             # This string is similar to the relevant configuration emitted by flytectl in the cases of both demo and sandbox.