-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support pandas 2 in flytekit #1818
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
should probably add pandas to |
I think we'll also need to add pandas to the Dockerfile |
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1818 +/- ##
==========================================
- Coverage 85.98% 85.97% -0.01%
==========================================
Files 308 308
Lines 22997 23027 +30
Branches 3474 3480 +6
==========================================
+ Hits 19773 19798 +25
+ Misses 2620 2618 -2
- Partials 604 611 +7 ☔ View full report in Codecov by Sentry. |
Very interesting that we don't have to change any of code in structured dataset (that probably means that we were already leaning on pyarrow in the way pandas 2 expects). How else did you test this, @pingsutw ? @cosmicBboy , did you take this for a spin? |
so does this mean, that flytekit will simply work with pandas and pandas2? depending on what the user installs? |
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
From other projects, I have heard that lazy loading can break workflows. This has came up in the flytekit's databricks plugin: flyteorg/flyte#3853 |
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Thank you! |
@pingsutw Congrats on getting this merged. Do you know when this will be released? |
@ringohoffman we plan to start cutting a new release next week |
TL;DR
Remove pandas from default dependencies, and support pandas 2 in flytekit
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#3928
Follow-up issue
NA