-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support pandas 2 in flytekit #1818
Merged
Merged
Changes from 25 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
6c15fda
remove pandas
pingsutw e4a5e55
update dev requirement
pingsutw 1b49769
update dev requirement
pingsutw 909fbce
update dev requirement
pingsutw f01e3b7
fix tests
pingsutw 3962fe6
return dummy module if module is not installed
pingsutw 015a0ac
Merge branch 'master' of github.com:flyteorg/flytekit into remove-pandas
pingsutw 68c032c
nit
pingsutw 30eee83
fixed tests
pingsutw 0347700
nit
pingsutw 8e0b58f
fixed tests
pingsutw 4fb0c03
fixed tests
pingsutw 4d30607
fixed tests
pingsutw e2b5450
fixed tests
pingsutw 3e64dcb
nit
pingsutw bf968f3
Add tests
pingsutw ae53480
lint
pingsutw c2921d0
lint
pingsutw df88479
merged master
pingsutw 6d5d9fb
merged master
pingsutw d3b8e5f
add pyarrow to dev
pingsutw 2e88e74
merged master
pingsutw 4edec78
merged master
pingsutw 5f477c7
nit
pingsutw fdaa5f6
rename
pingsutw f6ab978
Test pandas 1 & 2
pingsutw 10b00c3
Merged master
pingsutw e68da19
update GA workflow
pingsutw c57c0fe
update GA workflow
pingsutw 94c9aca
unit test without pandas
pingsutw 10d8466
fix tests
pingsutw e15910d
lint
pingsutw d5669da
fix tests
pingsutw 85a431b
Add pyarrow back
pingsutw 97bd5e9
Skip some tests
pingsutw 242436d
Skip some tests
pingsutw bb7ab63
Fix tests
pingsutw 22ba6c0
fix tests
pingsutw dc6119f
nit
pingsutw 1dcba35
lint
pingsutw 0e8ea2c
Fix tests
pingsutw b29ec36
Fix tests
pingsutw e6c3a0d
Skip specific test
pingsutw 8a2d047
nit
pingsutw b311082
update-pytest-mark
pingsutw 37af712
fix-test
pingsutw 68fcc8f
lint
pingsutw b47f436
Fix tests
pingsutw 788f918
fix-test
pingsutw 18c4fb8
lint
pingsutw 97b8547
fix-test
pingsutw 1185631
uninstall -y
pingsutw 351d673
fixed test
pingsutw d05a11f
Merged master
pingsutw 30a986a
ni
pingsutw 55c8847
update test_union_in_dataclass
pingsutw 1da781d
lint
pingsutw cae2746
Merge branch 'master' of github.com:flyteorg/flytekit into remove-pandas
pingsutw a155a0e
Update github workflow
pingsutw 915818f
nit
pingsutw cef8fae
force reinstall
pingsutw 9a8278b
nit
pingsutw 52a1143
nit
pingsutw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import pytest | ||
|
||
from flytekit.lazy_import.lazy_module import LazyModule, lazy_module | ||
|
||
|
||
def test_lazy_module(): | ||
mod = lazy_module("pandas") | ||
assert mod.__name__ == "pandas" | ||
mod = lazy_module("fake_module") | ||
assert isinstance(mod, LazyModule) | ||
with pytest.raises(ImportError, match="Module fake_module is not yet installed."): | ||
print(mod.attr) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this would be too annoying for local development? We'll remember to install pandas + pyarrow to enable some for the test suite.
I am okay with it. For others maybe a comment:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added pandas to dev-requirement, and uninstall it in the GA workflow instead.