This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
Fix fossa test always fail #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When fixing an issue related to container analysis not exiting with a success message, we regressed
fossa testby addinglogWithExitbut not returning a success. This fix addressed the issues, but sincelogWithExitreturns()on success, we always hit theexitFailureat the bottom of the file.This PR further reinforces the need for improved integration testing. https://github.com/fossas/team-analysis/issues/437
Acceptance criteria
This PR is making sure that we
Testing plan
I built a binary locally with the changes and validated that when running fossa test I got an exit code of 0. Testing with the current spectrometer binary is recommended as well to observe the changes
$?should show that the exit code was0.Risks
I don't believe there are any risks associated with this.
References
https://teamfossa.slack.com/archives/G01DUC2JW3B/p1625589871002400
Checklist
haskell-language-server) any haskell files I touched in this PR.docs/.Changelog.mdif this change is externally facing. If this PR did not mark a release, I added my changes into an# Unreleasedsection at the top.