This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skilly-lily
force-pushed
the
yarn-npm-merge
branch
from
September 21, 2021 23:15
9ac5a89
to
65eaebc
Compare
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
skilly-lily
commented
Sep 22, 2021
meghfossa
reviewed
Sep 22, 2021
Ran into few issues with javascript directory in https://github.com/meghfossa/example-projects |
@meghfossa I would only expect the |
skilly-lily
force-pushed
the
yarn-npm-merge
branch
from
September 28, 2021 00:58
f15980b
to
312ab2a
Compare
skilly-lily
force-pushed
the
yarn-npm-merge
branch
2 times, most recently
from
September 30, 2021 22:44
2d0835f
to
6733920
Compare
skilly-lily
force-pushed
the
yarn-npm-merge
branch
from
October 28, 2021 22:13
f4d8bbd
to
a368257
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implementation status:
npm
yarn
version 1yarn
version 2Acceptance criteria
Strategy.Node
are well-laid-out.hlint
config)Testing plan
Testing is divided into 2 categories:
package.json
--output
modeprojects
field of the output, and are present insourceUnits.Imports
.Reviewer notes
Keep an eye out for my own reminder comments. This PR will not be merged until those are complete and confirmed by a reviewer, but they may stay during development to speedup customer interactions.
When reviewing, note the new modules, and review their API layouts:
Data.Glob
- A strongly-typed wrapper around some basics of theSystem.Filepattern
module, as well as some helpers needed to work withPath b t
.Data.Tagged
- A strongly-typed wrapper around any value, such that the tag cannot be coerced silently. Use for when newtypes are not flexible enough, and has a functor instance so the the wrapped type may be modified without altering the tag.Graphing.Hydrate
- A generichydrate
, and a specializedhydrateDepsEnvs
, which takes dep environments within a graph and recursively populates those environments to their children.Test.Effect
- A set of test utils and assertions which can be used alongside our effects. Most have identical names to theirTest.Hspec
counterparts.Risks
If there are any special features in our JS support currently, they may not be implemented.
References
closes fossas/team-analysis#707
Checklist
docs/
.Changelog.md
if this change is externally facing. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top.