This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
dep envs are now sets #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meghfossa
approved these changes
Sep 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Change
dependencyEnvironmentsto be aSet, as opposed to a list. This is needed for #374.Part of the work for fossas/team-analysis#707
This change is REALLY simple, and only has one logical change, which is to use
Setinstead of list, but we use this everywhere, so the diff seems huge.Checklist
docs/.Changelog.mdif this change is externally facing. If this PR did not mark a release, I added my changes into an# Unreleasedsection at the top.