fix: Disable auto-filling of country name in tax popup #5286
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/9lsrsa4q2 |
Codecov Report
@@ Coverage Diff @@
## development #5286 +/- ##
===============================================
- Coverage 22.90% 22.80% -0.10%
===============================================
Files 491 491
Lines 5230 5239 +9
Branches 36 37 +1
===============================================
- Hits 1198 1195 -3
- Misses 4027 4039 +12
Partials 5 5
Continue to review full report at Codecov.
|
iamareebjamal
changed the title
| @@ -6,7 +6,7 @@ | |||
| <div class="field"> | |||
| <label class="required">{{t 'Choose country'}}</label> | |||
| <UiDropdown @class="search selection" @selected={{this.tax.country}} @forceSelection={{false}} @fullTextSearch={{true}}> | |||
| <Input @type="hidden" @autocomplete="no" @id="tax_country" @value={{this.tax.country}} /> | |||
| <Input @type="hidden" @autocomplete="some-random-string" @id="tax_country" @value={{this.tax.country}} /> | |||
There was a problem hiding this comment.
Instead of some-random-string, try country
If it does not work, then something else which doesn't look like a placeholder
There was a problem hiding this comment.
It is also working by doing @autocomplete = "tax-country" instead of using "some-random-string". Should I do that in all others also?
There was a problem hiding this comment.
Done sir, please check now.
ShreyanshSrivastava
dismissed stale reviews from maze-runnar and mariobehling
via
7a71c59
| @@ -21,20 +21,20 @@ | |||
| </div> | |||
| <div class="field"> | |||
| <label class="required">{{t 'Tax name'}}</label> | |||
| <Input @type="text" @id="tax_name" @value={{this.tax.name}} /> | |||
| <Input @type="text" @autocomplete="tax-name" @id="tax_name" @value={{this.tax.name}} /> | |||
There was a problem hiding this comment.
Unneeded. Just do this in country field
There was a problem hiding this comment.
@iamareebjamal Please check now
| @@ -21,20 +21,20 @@ | |||
| </div> | |||
| <div class="field"> | |||
| <label class="required">{{t 'Tax name'}}</label> | |||
| <Input @type="text" @id="tax_name" @value={{this.tax.name}} /> | |||
| <Input @type="text" @autocomplete="some-random-string" @id="tax_name" @value={{this.tax.name}} /> | |||
There was a problem hiding this comment.
@iamareebjamal should I remove the whole autocomplete attribute from here only?
There was a problem hiding this comment.
The issue is about country field, so why add this here?
There was a problem hiding this comment.
@iamareebjamal Sir I have to add this autocomplete to every input field, to prevent it from getting auto-filled, and if I am removing it from there then auto-filling is not disabled for those fields
i.e. all information will get auto-filled like it is behaving now in eventyay.com
There was a problem hiding this comment.
As I understand, the issue is about country autofill disabling, not all fields
There was a problem hiding this comment.
Actually sir I think should be the other way round as stated by @mariobehling, because we want that a person adding his or her tax info should not have the option to autofill all the fields based on the browsers form's memory that's why we want to disable it and only allow the autofilling of country name, and not other sensitive information that is user-specific.
There was a problem hiding this comment.
@mariobehling There is still confusion. Do we want to?
- 1. Disable all browser autocomplete including name, address,country, etc
- 2. Disable browser autocomplete for country and allow browser autocomplete for other form fields
- 3. Disable browser autocomplete for all fields and allow browser autocomplete for country field
Our suggestion autocomplete will be shown in all 3 cases. If we want 2., then we don't require to change a lot of things as they are in the PR, just one field.
There was a problem hiding this comment.
Thanks for clarifying. We need:
- Disable browser autocomplete for country and allow browser autocomplete for other form fields
There was a problem hiding this comment.
@ShreyanshSrivastava Please remove the autocomplete tag from other fields
There was a problem hiding this comment.
@iamareebjamal Done
| @@ -21,20 +21,20 @@ | |||
| </div> | |||
| <div class="field"> | |||
| <label class="required">{{t 'Tax name'}}</label> | |||
| <Input @type="text" @id="tax_name" @value={{this.tax.name}} /> | |||
| <Input @type="text" @id="tax_name" @value={{this.tax.name}} /> | |||
There was a problem hiding this comment.
Extra space. Ensure that no changes other than in country field are present in the files changed
There was a problem hiding this comment.
@iamareebjamal Sorry sir didn't notice that. Removed the extra spaces
iamareebjamal
changed the title
fix: Disable auto-filling of country name in tax popup (fossasia#5286)
Fixes #4504
Short description of what this resolves:
The proposed changes disabled the auto-filling of information other than country name during the Tax Pop-up in wizard step-1.
Changes proposed in this pull request:
Old View
New View