Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Disable auto-filling of country name in tax popup #5286

Merged
merged 7 commits into from
Oct 12, 2020
Merged

fix: Disable auto-filling of country name in tax popup #5286

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f6b892e
Disabled auto-filling of information during Tax Pop-up in wizard step-1
ShreyanshSrivastava Oct 10, 2020
7a71c59
replaced placeholder string by respective field name in autocomplete …
ShreyanshSrivastava Oct 11, 2020
87939f2
Merge branch 'development' into development
ShreyanshSrivastava Oct 11, 2020
bb1767d
placeholder replaced by country in autocomplete attribute
ShreyanshSrivastava Oct 11, 2020
9ab14af
some update of yarn and package.json
ShreyanshSrivastava Oct 11, 2020
32b1f07
changed the autocomplete attribute of input feilds
ShreyanshSrivastava Oct 12, 2020
c39577c
removed extra space from input attributes
ShreyanshSrivastava Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions app/templates/components/modals/tax-info-modal.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<div class="field">
<label class="required">{{t 'Choose country'}}</label>
<UiDropdown @class="search selection" @selected={{this.tax.country}} @forceSelection={{false}} @fullTextSearch={{true}}>
<Input @type="hidden" @autocomplete="no" @id="tax_country" @value={{this.tax.country}} />
<Input @type="hidden" @autocomplete="tax-country" @id="tax_country" @value={{this.tax.country}} />
<i class="dropdown icon"></i>
<div class="default text">{{t 'Select country'}}</div>
<div class="menu">
Expand All @@ -21,20 +21,20 @@
</div>
<div class="field">
<label class="required">{{t 'Tax name'}}</label>
<Input @type="text" @id="tax_name" @value={{this.tax.name}} />
<Input @type="text" @id="tax_name" @value={{this.tax.name}} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space. Ensure that no changes other than in country field are present in the files changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal Sorry sir didn't notice that. Removed the extra spaces

</div>
<div class="field">
<label class="required">{{t 'Tax rate'}}</label>
<Input @type="number" @id="tax_rate" @min={{0}} @max={{100}} @value={{this.tax.rate}} />
<Input @type="number" @id="tax_rate" @min={{0}} @max={{100}} @value={{this.tax.rate}} />
</div>
<div class="field">
<label class="required">{{t 'Tax ID'}}</label>
<Input @type="text" @id="tax_id" @value={{this.tax.taxId}} />
<Input @type="text" @id="tax_id" @value={{this.tax.taxId}} />
</div>
<div class="field">
<label>{{t 'Tax Invoices'}}</label>
<div class="ui checkbox">
<Input @type="checkbox" @id="send_tax_invoices" @name="send_tax_invoices" @checked={{this.tax.shouldSendInvoice}} />
<Input @type="checkbox" @id="send_tax_invoices" @name="send_tax_invoices" @checked={{this.tax.shouldSendInvoice}} />
<label for="send_tax_invoices">
<strong>{{t 'Send tax invoice to attendees'}} : </strong>
<span class="text muted">
Expand All @@ -46,26 +46,26 @@
</div>
<div class="field">
<label>{{t 'Registered Company'}}</label>
<Input @type="text" @id="tax_invoice_company" @value={{this.tax.registeredCompany}} />
<Input @type="text" @id="tax_invoice_company" @value={{this.tax.registeredCompany}} />
</div>
<div class="field">
<label>{{t 'Business Address'}}</label>
<Textarea @rows={{3}} @id="tax_invoice_address" @value={{this.tax.address}} /> </div>
<Textarea @rows={{3}} @id="tax_invoice_address" @value={{this.tax.address}} /> </div>
<div class="field">
<label>{{t 'City'}}</label>
<Input @type="text" @id="tax_invoice_city" @value={{this.tax.city}} />
<Input @type="text" @id="tax_invoice_city" @value={{this.tax.city}} />
</div>
<div class="field">
<label>{{t 'State'}}</label>
<Input @type="text" @id="tax_invoice_state" @value={{this.tax.state}} />
<Input @type="text" @id="tax_invoice_state" @value={{this.tax.state}} />
</div>
<div class="field">
<label>{{t 'Zipcode'}}</label>
<Input @type="text" @id="tax_invoice_zipcode" @value={{this.tax.zip}} />
<Input @type="text" @id="tax_invoice_zipcode" @value={{this.tax.zip}} />
</div>
<div class="field">
<label>{{t 'Text for invoice footer (optional)'}}</label>
<Textarea @rows={{3}} @id="tax_invoice_footer" @value={{this.tax.invoiceFooter}} /> </div>
<Textarea @rows={{3}} @id="tax_invoice_footer" @value={{this.tax.invoiceFooter}} /> </div>
<div class="grouped fields">
<label for="privacy">{{t 'Add or Include Tax Fee'}}</label>
<div class="field">
Expand Down