-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: View Action for Speaker #5390
feat: View Action for Speaker #5390
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ppfrvafg7 |
This pull request introduces 1 alert when merging c43953e into 54059ca - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 630c3b0 into 54059ca - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## development #5390 +/- ##
===============================================
+ Coverage 23.29% 23.30% +0.01%
===============================================
Files 489 491 +2
Lines 5122 5127 +5
Branches 37 37
===============================================
+ Hits 1193 1195 +2
- Misses 3924 3927 +3
Partials 5 5
Continue to review full report at Codecov.
|
|
app/templates/components/ui-table/cell/events/view/speakers/cell-buttons.hbs
Show resolved
Hide resolved
@iamareebjamal Actually we can revert this back to <div class="hidden ui divider"></div> and it will work absolutely fine. And talking about why i removed <LinkTo/> This is because LinkTo was taking to specified defined page and inside LinkTo an action is used which also transit the page to respected pages so there was shifting of pages from one to other only on clicking on button once. This is session file {{this.record}}
<br><br>
<div class="ui horizontal compact basic buttons">
<UiPopup @content={{t "View Session"}} @class="ui icon button" @click={{action this.props.actions.viewSession this.extraRecords.id this.extraRecords.event.id}} @position="left center">
<i class="unhide icon"></i>
</UiPopup>
{{#if (not this.extraRecords.isLocked)}}
<UiPopup @content={{t "Edit Session"}} @class="ui icon button" @click={{action this.props.actions.editSession this.extraRecords.id this.extraRecords.event.id}} @position="left center">
<i class="edit icon"></i>
</UiPopup>
{{/if}}
<UiPopup @content={{t "Delete Session"}} @click={{action (confirm (t "Are you sure you would like to delete this Session?") (action this.props.actions.deleteSession this.extraRecords.id))}} @class="ui icon button" @position="left center">
<i class="trash icon"></i>
</UiPopup>
</div> |
app/templates/components/ui-table/cell/events/view/speakers/cell-buttons.hbs
Outdated
Show resolved
Hide resolved
app/templates/components/ui-table/cell/events/view/speakers/cell-buttons.hbs
Outdated
Show resolved
Hide resolved
Here is an overview of what got changed by this pull request: Complexity increasing per file
==============================
- app/controllers/public/speaker/view.js 3
- app/controllers/events/view/speakers/list.js 1
- tests/unit/routes/public/speaker/view-test.js 1
See the complete overview on Codacy |
@@ -15,7 +15,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) { | |||
{ | |||
name : 'Name', | |||
valuePath : 'name', | |||
extraValuePaths : ['id', 'event'], | |||
extraValuePaths : ['id'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this won't work as I said this.extraRecords is not complete speaker object, it has prop of speaker object that are defined in extraValuePaths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamareebjamal its not working with this change, please see to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, please send a PR with this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK and specify same issue #4559 with it or should I create new issue and then do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see PR #5405
Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>
Fixes #4559
Short description of what this resolves:
View Action was transiting the page to editing the speaker info, so the issue is resolved.
Changes proposed in this pull request:
Checklist
development
branch.Before
View action button was taking to Edit page.
After
Now View Action is taking to new view speaker page
on clicking the speaker