Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add extra value paths for view speaker handler #5405

Merged
merged 2 commits into from
Oct 28, 2020
Merged

fix: Add extra value paths for view speaker handler #5405

merged 2 commits into from
Oct 28, 2020

Conversation

divyamtayal
Copy link
Member

Fixes #4559

Short description of what this resolves:

Event id was undefined, now fixed

Changes proposed in this pull request:

  • Added Speaker Property

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/n5sftbxb0
✅ Preview: https://open-event-frontend-git-view-action-4559.eventyay.now.sh

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #5405 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5405   +/-   ##
============================================
  Coverage        23.30%   23.30%           
============================================
  Files              491      491           
  Lines             5127     5127           
  Branches            37       37           
============================================
  Hits              1195     1195           
  Misses            3927     3927           
  Partials             5        5           
Impacted Files Coverage Δ
app/controllers/events/view/speakers/list.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba0117...6dc06a9. Read the comment docs.

@divyamtayal
Copy link
Member Author

@iamareebjamal Please review this PR.

@iamareebjamal iamareebjamal changed the title Add Speaker Property fix: Add extra value paths for view speaker handler Oct 28, 2020
@auto-label auto-label bot added the fix label Oct 28, 2020
@iamareebjamal iamareebjamal merged commit 695ceee into fossasia:development Oct 28, 2020
@divyamtayal divyamtayal deleted the view-action-4559 branch October 30, 2020 04:52
sansyrox pushed a commit to sansyrox/open-event-frontend that referenced this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View action for speaker not working in dashboard
2 participants