🚀 Release v6.5.2 #11647

ncoden · 2019-01-12T00:05:53Z

Foundation v6.5.2

This version provide various bug fixes and improvements for Foundation 6.5, update the documentation and improve the test workflow.

Note about this pull request: As this version was built to have the best compatibility with v6.4.4-rc1, we used a dedicated branch and manually picked safe changes from the development branch develop, excluding API evolutions and breaking changes. These imported changes are the Use pull request #xxx commits you can see in this pull request. Development will continue on develop and will lead to a future release with all changes, including new features and breaking changes.

Changes from v6.5.1

Fixes and improvements

🐛 fix: use concat return value for Trigger names #11592 - Fix an issue with Triggers utility when the plugin name is an object (@DanielRuf)
🐛 fix: import used Touch utility in Dropdown and Reveal #11604 #11605 - Import used Touch utility in Dropdown and Reveal (@ncoden, Missing Touch utility in Dropdown and Reveal #11604)
🐛 fix: Fixed submenu bounce if nested #11606 - Fix Accordion bouncing with active submenus on initialization (@pascalknecht)
🐛 fix: fix SmoothScroll not applying custom options #11622 - Fix SmoothScroll ignoring the passed options (@ben-z, SmoothScroll options can't be set #11620)
🐛 Fix wrong implementation of horizontal centering the grid-container #11634 - Prevent the XY Grid container to override top/bottom margins (@HarwinBorger, Grid-container has margin top and bottom set on 0 (zero) #11633)
📖 docs: update the CodePen test case template #11608 - Update CodePen test case templates to Foundation v6.5.1 (@ncoden)
📖 docs: add availability of features in the XY Grid (X/Y/both) #11610 - Add availability of features in the XY Grid doc (X/Y only or both) (@ncoden, Documentation on Gutters in the XY Grid doesn't mention the y-axis #11601)
📖 docs: remove warning for abandoned deprecations #10540 #11619 - Remove warning for abandoned deprecations in SCSS utilities (@ncoden, Please fix the docs re: visibility #10540)
📖 Update license date #11644 - Update license and copyright notices to 2019 (@benhc123)
🚚 chore: temporary disable tree-shaking #11586 #11607 - Revert to labelling Foundation as "with side effects" (@ncoden, [REGRESSION] Calling $(document).foundation() fails in production builds #11586)
🚚 fix: fix imports for AMD/CommonJs #11618 - Fix names of modules for AMD/CommonJs (@ncoden, missing files foundation.core.utils.js and foundation.core.plugin.js in dist/js/plugins #11614)

Internal

🛠️ fix: remove duplicate margin-bottom from grid example #11595 - Remove duplicate CSS properties in Grid examples (@DanielRuf)
🛠️ chore: remove unused background rules in docs #11596 - Remove unused background CSS properties in doc (@DanielRuf)
🛠️ fix: remove duplicate position:absolute in progress-bar #11597 - Remove duplicate CSS properties in Progress bar (@DanielRuf)
🛠️ fix: remove duplicate border-left-width:0 in drilldown #11598 - Remove duplicate CSS properties in Drilldown (@DanielRuf)
🛠️ refactor: remove duplicate code in util.nest #11636 - Remove duplicate code in Nest utilities (@DanielRuf)
💻 tests: test on Linux, macOS and Windows #11538 - Run tests on Linux, macOS and Windows (@DanielRuf)
💻 ci: test latest Node.js #11635 - Run tests on latest Node.js version (@DanielRuf)

Contributors

Ben Holden-Crowther (@benhc123) [1]
Ben Zhang (@ben-z) [3]
Daniel Ruf (@DanielRuf) [13]
Harwin Borger (@HarwinBorger) [1]
Nicolas Coden (@ncoden) [17]
Pascal Knecht (@pascalknecht) [1]

Release Checklist

…fig for v6.5.0 4d9270f chore: fix plugins UMD external names 7f5aa78 docs: add documentation for the webpack UMD configuration 4124057 chore: fix plugins' UMD root variables names 3fa6741 test: add test for imports via AMD 91353db docs: improve description for the webpack externals config in build script a69a577 docs: improve docs for the root namespace in build script 5e42209 docs: improve docs of the "getUmdEntry" build utility Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…emove-duplicate-code for v6.5.0 5cd6267 refactor: remove duplicate code in util.nest Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…os-windows for v6.5.0 d0f6c3b tests: test on Linux, macOS and Windows 8273493 tests: use Node.js 6, 8 and 10 78b516f tests: run Browswestack tests only on one platform 6234087 ci: use Yarn e457b19 chore: downgrade mocha-headless-chrome for now b453e55 fix: downgrade doiuse to support Node.js 6 0c92518 fix: disable Yarn GPG so it doesn't prevent the Travis build to finish 3f3c331 chore: cache Yarn in Travis Co-Authored-By: Daniel Ruf <daniel.ruf@ueberbit.de> Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr> Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…s for v6.5.0 0222ddc ci: test latest Node.js Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…r-margin-value for v6.5.0 2b71513 Fix wrong implementation of centering the grid-container Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…s for v6.5.0 ae8363a Fix smoothscroll not applying custom options 8dd7065 fix: correctly remove the event listener in _destroy 9767057 fix: fix spelling Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…-depreciation-notices-10540 for v6.5.0 367468e docs: remove warning for abandoned deprecations foundation#10540 Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…tures for v6.5.0 30601b7 docs: document availability of the XY Grid for X/Y/both grids ff2943b docs: fix "grid-padding-y" class in XY Grid docs Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…ing for v6.5.0 d8bcc3a chore: temporary disable tree-shaking foundation#11586 Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…codepen-template for v6.5.0 063e1be docs: update the CodePen test case template Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…e for v6.5.0 0d50a60 Fixed submenu bounce if nested 165a371 refactor: improve readibility and add docs in "AccordionMenu.down()" Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr> Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…es for v6.5.0 40833df fix: import used Touch utility in Dropdown and Reveal Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…cat-return-value for v6.5.0 5b92798 fix: use concat return value for Trigger names Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…ed-background-rules for v6.5.0 7acd41d chore: remove unused background rules in docs Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…-duplicate-border-left-width for v6.5.0 b6a3c65 fix: remove duplicate border-left-width:0 in drilldown Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…icate-margin-bottom for v6.5.0 bebce87 fix: remove duplicate margin-bottom from grid example Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…ove-duplicate-position-absolute for v6.5.0 8cd5454 fix: remove duplicate position:absolute in progress-bar Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

2b6af27 Update license date 848b38a docs: update copyright policies Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr> Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

DanielRuf · 2019-01-12T11:27:29Z

Hm, not sure if it is good to mix Yarn and npm commands.

But weird that the Windows builds are not green anymore. I'll contact the Travis XI team.

https://travis-ci.org/zurb/foundation-sites/jobs/478599445#L176

ncoden · 2019-01-12T13:38:33Z

Hm, not sure if it is good to mix Yarn and npm commands.

I don't know. But it's the same on develop

But weird that the Windows builds are nit green anymore. I'll contact the Travis XI team.

There is issues with Yarn+Windows on Travis. This, There appears to be trouble with your network connection times to times.

glen-84 · 2019-01-15T09:51:37Z

Will this be released soon?

v6.4.3 is broken because of main pointing to ES6 code.
v6.5.1 is broken because of #11586.

😞

ncoden · 2019-01-15T09:57:14Z

@glen-84 See #11586 (comment)

We are waiting for Travis to pass, there is some issues with Window. This should be released by the end of the week.

glen-84 · 2019-01-15T10:56:47Z

Are you running Windows locally, or another OS? I mean, is this specific to Travis CI, or a general issue with Windows builds?

I see that "Windows builds are in early access stage".

glen-84 · 2019-01-15T11:22:22Z

Error: Failed to launch chrome!
[0112/003942.079:ERROR:main_dll_loader_win.cc(134)] Failed to load Chrome DLL from C:\Users\travis\build\zurb\foundation-sites\node_modules\puppeteer.local-chromium\win64-594312\chrome-win\chrome.dll: The specified module could not be found. (0x7E)

https://travis-ci.community/t/puppeteer-not-working-on-windows-container/354

It might be worth trying the latest version of Puppeteer?

ncoden · 2019-01-15T13:57:36Z

@glen-84 This is not related. See https://travis-ci.org/zurb/foundation-sites/jobs/478599448#L281

glen-84 · 2019-01-15T14:57:40Z

I see.

It looks like lots of people are seeing this error ... yarnpkg/yarn#4890 yarnpkg/yarn#5259.

Is it worth trying --network-timeout 1000000?

... or switching to npm. 🙂

Did you or @DanielRuf contact Travis support?

DanielRuf · 2019-01-15T15:31:38Z

... or switching to npm

npm has more and bigger issues.

https://travis-ci.community/t/yarn-network-troubles/333/2

DanielRuf · 2019-01-15T17:04:12Z

It is the Puppeteer issue.

https://travis-ci.org/zurb/foundation-sites/jobs/478599448#L290

develop has a newer version. So this should be fine to update and cherry-pick the update of the dependency @ncoden

glen-84 · 2019-01-17T07:08:04Z

@ncoden Will you be able to try this soon?

glen-84 · 2019-01-21T07:14:05Z

Is there anything that I can do to help?

… for v6.5.0 ba8f9d3 docs: fix various typos for available Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

189dd49 fixed overridden 03fc63e docs: fix various "overridden" in utility docs Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr> Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

…es-2019-01-13 for v6.5.0 7a4057f chore: update dependencies (2019-01-13) 5090e7c chore: increase Yarn network timeout in Travis 2f2b585 chore: update sub-dependency pupeeteer for Travis on Windows aff8bd7 chore: ensure to keep dep resolutions when relocking deps Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

ncoden and others added 19 commits November 15, 2018 23:17

Merge branch 'master-v6.5' into develop-v6.5

78fc378

Use pull request foundation#11636 from DanielRuf/refactor/util.nest-r…

ffc6838

…emove-duplicate-code for v6.5.0 5cd6267 refactor: remove duplicate code in util.nest Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11635 from DanielRuf/ci/test-latest-nodej…

0e5ac9e

…s for v6.5.0 0222ddc ci: test latest Node.js Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11634 from HarwinBorger/fix-grid-containe…

59269b9

…r-margin-value for v6.5.0 2b71513 Fix wrong implementation of centering the grid-container Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11622 from ben-z/fix-smooth-scroll-option…

76e8b0d

…s for v6.5.0 ae8363a Fix smoothscroll not applying custom options 8dd7065 fix: correctly remove the event listener in _destroy 9767057 fix: fix spelling Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11619 from ncoden/docs/remove-invalid-6-5…

e80a37b

…-depreciation-notices-10540 for v6.5.0 367468e docs: remove warning for abandoned deprecations foundation#10540 Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11610 from ncoden/docs/xy-grid-x-vs-y-fea…

eeb6dd3

…tures for v6.5.0 30601b7 docs: document availability of the XY Grid for X/Y/both grids ff2943b docs: fix "grid-padding-y" class in XY Grid docs Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11607 from ncoden/chore/disable-tree-shak…

f72055f

…ing for v6.5.0 d8bcc3a chore: temporary disable tree-shaking foundation#11586 Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11608 from ncoden/docs/update-foundation-…

94f88b8

…codepen-template for v6.5.0 063e1be docs: update the CodePen test case template Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11605 from ncoden/fix/import-used-utiliti…

24ee9ff

…es for v6.5.0 40833df fix: import used Touch utility in Dropdown and Reveal Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11592 from DanielRuf/fix/triggers-use-con…

ad2a6d6

…cat-return-value for v6.5.0 5b92798 fix: use concat return value for Trigger names Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11596 from DanielRuf/fix/docs-remove-unus…

feb4b3b

…ed-background-rules for v6.5.0 7acd41d chore: remove unused background rules in docs Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11598 from DanielRuf/fix/drilldown-remove…

6b13749

…-duplicate-border-left-width for v6.5.0 b6a3c65 fix: remove duplicate border-left-width:0 in drilldown Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11595 from DanielRuf/fix/docs-remove-dupl…

cd5250e

…icate-margin-bottom for v6.5.0 bebce87 fix: remove duplicate margin-bottom from grid example Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11597 from DanielRuf/fix/progress-bar-rem…

124f45f

…ove-duplicate-position-absolute for v6.5.0 8cd5454 fix: remove duplicate position:absolute in progress-bar Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11644 from benhc123/patch-5 for v6.5.0

bd58eb8

2b6af27 Update license date 848b38a docs: update copyright policies Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr> Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

ncoden added the 🚀 Release label Jan 12, 2019

ncoden requested a review from DanielRuf January 12, 2019 00:08

DanielRuf approved these changes Jan 22, 2019

View reviewed changes

ncoden and others added 3 commits January 22, 2019 17:42

Use pull request foundation#11648 from ncoden/docs/fix-available-typo…

fad9c25

… for v6.5.0 ba8f9d3 docs: fix various typos for available Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

Use pull request foundation#11658 from 0xflotus/patch-1 for v6.5.0

8d4f29b

189dd49 fixed overridden 03fc63e docs: fix various "overridden" in utility docs Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr> Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>

ncoden force-pushed the release/v6.5.2 branch from 38d8a58 to 4cc8b25 Compare January 22, 2019 17:05

ncoden added 4 commits January 23, 2019 15:15

chore: bump version for v6.5.2

090bb84

chore: update lockfiles for v6.5.2

af34d07

chore: update dist files for v6.5.2

a0547b1

docs: update docs for v6.5.2

f2ad47f

ncoden force-pushed the release/v6.5.2 branch from 4cc8b25 to f2ad47f Compare January 23, 2019 14:15

chore: update meteor lockfile for v6.5.2

dcab002

ncoden merged commit 0459382 into foundation:master-v6.5 Jan 23, 2019

ncoden mentioned this pull request Jan 25, 2019

🚀 Release v6.5.3 #11664

Merged

11 tasks

This was referenced Mar 10, 2020

[Snyk] Upgrade foundation-sites from 6.5.3 to 6.6.1 BarkleyREI/brei-project-scaffold#27

Closed

[Snyk] Upgrade foundation-sites from 6.5.3 to 6.6.1 BarkleyREI/brei-sass-boilerplate#81

Closed

renovate bot mentioned this pull request Aug 7, 2021

chore(deps): update dependency foundation to v6 uPortal-Project/resource-server#184

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚀 Release v6.5.2 #11647

🚀 Release v6.5.2 #11647

ncoden commented Jan 12, 2019 •

edited

Loading

DanielRuf commented Jan 12, 2019 •

edited

Loading

ncoden commented Jan 12, 2019

glen-84 commented Jan 15, 2019

ncoden commented Jan 15, 2019

glen-84 commented Jan 15, 2019

glen-84 commented Jan 15, 2019

ncoden commented Jan 15, 2019

glen-84 commented Jan 15, 2019

DanielRuf commented Jan 15, 2019 •

edited

Loading

DanielRuf commented Jan 15, 2019

glen-84 commented Jan 17, 2019

glen-84 commented Jan 21, 2019

🚀 Release v6.5.2 #11647

🚀 Release v6.5.2 #11647

Conversation

ncoden commented Jan 12, 2019 • edited Loading

Foundation v6.5.2

Changes from v6.5.1

Fixes and improvements

Internal

Contributors

Release Checklist

DanielRuf commented Jan 12, 2019 • edited Loading

ncoden commented Jan 12, 2019

glen-84 commented Jan 15, 2019

ncoden commented Jan 15, 2019

glen-84 commented Jan 15, 2019

glen-84 commented Jan 15, 2019

ncoden commented Jan 15, 2019

glen-84 commented Jan 15, 2019

DanielRuf commented Jan 15, 2019 • edited Loading

DanielRuf commented Jan 15, 2019

glen-84 commented Jan 17, 2019

glen-84 commented Jan 21, 2019

ncoden commented Jan 12, 2019 •

edited

Loading

DanielRuf commented Jan 12, 2019 •

edited

Loading

DanielRuf commented Jan 15, 2019 •

edited

Loading