fix: handle duplicate forkids #5939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The expected behavior is that |
|
this is rather a bug how me map the assigned uint256 forkids internally, because both forking off the same endpoint at the same height, so we need to change how we keep track of those, will fix shortly |
|
@mattsse ping |
|
@DaniPopes whoops, totally forgot about this. I took a page out of the cargo playbook and used an URL hack to make them unique, this was easier than rewriting the internal mappings... |
DaniPopes
requested changes
Nov 28, 2023
crates/forge/tests/it/repros.rs
Outdated
| @@ -198,3 +198,6 @@ test_repro!(6180); | |||
|
|
|||
| // https://github.com/foundry-rs/foundry/issues/6437 | |||
| test_repro!(6437); | |||
|
|
|||
| // <https://github.com/foundry-rs/foundry/issues/5935> | |||
| test_repro!(5935); | |||
mattsse
changed the title
DaniPopes
approved these changes
Nov 28, 2023
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5935
we have an edge case with forkids internally that can lead to an out of bounds bug if the same URL is used twice and the local mapping is updated
https://github.com/foundry-rs/foundry/blob/master/crates/evm/src/executor/backend/mod.rs#L1624-L1634