feat(debugger): Highlight memory region for any instruction #5940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyccan
changed the title
soyccan
changed the title
soyccan
changed the title
mattsse
requested changes
Sep 28, 2023
Evalir
requested changes
Sep 29, 2023
Move some in-function comments to the be function docs. Since now not only a memory word but a region of memory is highlighted, we changed some var name to be clear.
soyccan
added a commit
to soyccan/foundry
that referenced
this pull request
Dec 3, 2023
The debugger colors memory region for a variety of instructions that access the memory, as described in foundry-rs#5940. But there is a potential underflow if the size is 0 (where offset + size - 1 underflows). Change to a simpler and more robust way to index the memory region.
DaniPopes
added a commit
that referenced
this pull request
Dec 4, 2023
The debugger colors memory region for a variety of instructions that access the memory, as described in #5940. But there is a potential underflow if the size is 0 (where offset + size - 1 underflows). Change to a simpler and more robust way to index the memory region. Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlight memory region for any instruction in debugger
Motivation
Currently, debugger highlights the 32-byte memory word that is being read/write in cyan/red when an
MLOAD/MSTORE is encountered, respectively.
But there are quite a few instructions that access memory, e.g. CALL, CALLDATACOPY, SHA3...
This update is to colorize the memory region (which may be of any size) for all of them.
This is an enhancement relevant to #4440. A related work #4681 was to highlight unaligned memory.
Solution
All instructions that access memory are considered. Memory regions are highlighted in cyan/red for
read/write, consistent with MLOAD/MSTORE. Also, memory regions that are just written by the previous
instruction is highlighted in green. Memory regions may be any length.