fix(debugger): a potential underflow in memory highlighting #6508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debugger colors memory region for a variety of instructions that access the memory, as described in foundry-rs#5940. But there is a potential underflow if the size is 0 (where offset + size - 1 underflows). Change to a simpler and more robust way to index the memory region.
DaniPopes
approved these changes
Dec 4, 2023
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The debugger colors memory region for a variety of instructions that access the memory, as described in #5940. But there is a potential underflow if the size is 0 (where offset + size - 1 underflows).
Solution
Change to a simpler and more robust way to index the memory region.
Minor changes: Handle the potential out-of-bound access to the stack