fix: use both indexed and unindexed params when decoding logs #6174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Oct 30, 2023
Comment on lines
+362
to
+379
| /// Restore the order of the params of a decoded event, | ||
| /// as Alloy returns the indexed and unindexed params separately. | ||
| fn reconstruct_params(event: &Event, decoded: &DecodedEvent) -> Vec<DynSolValue> { | ||
| let mut indexed = 0; | ||
| let mut unindexed = 0; | ||
| let mut inputs = vec![]; | ||
| for input in event.inputs.iter() { | ||
| if input.indexed { | ||
| inputs.push(decoded.indexed[indexed].clone()); | ||
| indexed += 1; | ||
| } else { | ||
| inputs.push(decoded.body[unindexed].clone()); | ||
| unindexed += 1; | ||
| } | ||
| } | ||
|
|
||
| inputs | ||
| } |
There was a problem hiding this comment.
I feel like this should be supported by DecodedEvent perhaps
There was a problem hiding this comment.
Yep definitely, we should be able to do this through a method rather than manually
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
|
error unrelated? |
|
Yeah? Seems unrelated, from an external integration test that probably changed |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6121.
This bug happened because we were only adding labels for unindexed params. We now need to restore the order of the indexed and unindexed params as alloy returns them separately, to be able to assign the labels properly.