Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix windows external tests #6280

Merged
merged 3 commits into from
Nov 10, 2023
Merged

ci: fix windows external tests #6280

merged 3 commits into from
Nov 10, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Nov 10, 2023

Windows is here to ruin the day
I just want green CI for once

https://github.com/foundry-rs/foundry/actions/runs/6824376973

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll lose my shit if this makes CI consistently green
I don't think we ever achieved this due to fucking windows

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows should be banned.

@DaniPopes DaniPopes marked this pull request as draft November 10, 2023 15:29
@DaniPopes
Copy link
Member Author

Honestly I have no idea why this shit is failing and I cannot be bothered anymore

@DaniPopes DaniPopes marked this pull request as ready for review November 10, 2023 16:14
@DaniPopes DaniPopes mentioned this pull request Nov 10, 2023
@DaniPopes DaniPopes merged commit f27a771 into master Nov 10, 2023
19 checks passed
@DaniPopes DaniPopes deleted the dani/i-love-windows branch November 10, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants