fix: windows ci part 69 #6283
Merged
fix: windows ci part 69 #6283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/windows69
branch
from
1ab4f11
to
3eea839
Compare
Evalir
approved these changes
Nov 10, 2023
Comment on lines
+101
to
104
| #[cfg(windows)] | ||
| let st = cmd.status(); | ||
| #[cfg(not(windows))] | ||
| let st = cmd.status().unwrap(); |
There was a problem hiding this comment.
i'm tossing my pc out of the window if this is really what is screwing up windows ci
There was a problem hiding this comment.
It's just that this panics because Windows can't find the commands, and the only test that actually requires these commands is snekmate.
I added this in #6277
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I swear it's the last one