fix(forge): loadAllocs cheatcode doesn't persist when called in setUp
#6297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
reviewed
Nov 13, 2023
Comment on lines
+42
to
+44
| // Restore the state snapshot prior to the allocs file being loaded. | ||
| vm.revertTo(snapshotId); | ||
|
|
There was a problem hiding this comment.
@Evalir do we have confidence/good tests for snapshot/revertTo cheats? We don't verify that state was correctly reset after this call and I know there's been some bugs on those cheats in the past
There was a problem hiding this comment.
I did check it manually, but didn't commit them due to the tests in Snapshots.t.sol. Glad to add an explicit test for this in loadAllocs.t.sol, but figured we didn't want to cross-wires 😄
There was a problem hiding this comment.
Makes sense, I agree the tests for proper revertTo behavior are better suited elsewhere, so I'm ok leaving it as-is
mds1
approved these changes
Nov 13, 2023
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
loadAllocscheatcode currently does not persist loaded account information if it is called in thesetUpfunction. This is because none of the loaded accounts were marked as touched during the loading process.Solution
Touch each account that is loaded into the
revmjournal in theload_allocsfunction in the DB backend.Tests
Added a regression test for the fixed bug, asserting that the loaded accounts are persisted when the cheatcode is called in
setUp.