fix: ensure websocket is flushed #6347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
approved these changes
Nov 17, 2023
|
@mattsse was the websocket generating an error of some kind that wasn't being flushed? Any idea what that error is? |
|
no error, it just no longer always flushed the messages to the wire due to some API changes so it took forever to send new messages, that's why our tests were still passing... |
Oh yep, I see. Misread the code. Ok thanks, you guys are awesome. Really appreciate the quick fix.🙏 |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6345
regression introduced via tungseinite bump in #6321
ref snapview/tokio-tungstenite#284
TLDR: websocket sink no longer always handles poll_flush