-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove foundry-abi #6394
Conversation
FormatSpec::Hexadecimal => format!("0x{:x}", *self), | ||
FormatSpec::Hexadecimal => { | ||
let hex = format!("{self:x}"); | ||
format!("0x{}", hex.trim_start_matches('0')) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ruint hex fmt pitfall
assert_eq!("NaN", fmt_1("%i", &addr)); | ||
assert_eq!("NaN", fmt_1("%e", &addr)); | ||
assert_eq!("0xdEADBEeF00000000000000000000000000000000", fmt_1("%x", &addr)); | ||
assert_eq!("'0xdEADBEeF00000000000000000000000000000000'", fmt_1("%o", &addr)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added hex formatting for consistency with other byte arrays
proc-macro = true | ||
# proc-macro tests aren't fully supported by cargo-nextest archives | ||
test = false | ||
doc = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved all non-macro stuff to common, so flattened macros-impl into one crate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Motivation
Part 2/2 of removing
foundry-abi
.Follow-up to #6379
Needs alloy-rs/core#426Solution