Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump, unpatch Alloy #6416

Merged
merged 5 commits into from
Nov 24, 2023
Merged

chore(deps): bump, unpatch Alloy #6416

merged 5 commits into from
Nov 24, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Nov 23, 2023

Motivation

Blocked on bluealloy/revm#880

Solution

@DaniPopes DaniPopes marked this pull request as draft November 23, 2023 22:44
@mattsse
Copy link
Member

mattsse commented Nov 23, 2023

@DaniPopes we probably want this included in the reth_freez branch of revm

@DaniPopes
Copy link
Member Author

DaniPopes commented Nov 24, 2023

@mattsse do you mean I should use the branch in bluealloy/revm#875?

@mattsse
Copy link
Member

mattsse commented Nov 24, 2023

yeah, we're currently on reth_freeze

https://github.com/paradigmxyz/reth/blob/337fb311eebdc2e31e7ed257d4cc655ec7c557f0/Cargo.toml#L138-L139

main has still some unstable new API changes (especially inspector) that we want to stabilize first

@DaniPopes
Copy link
Member Author

I see, is it possible to cherry pick the alloy bump to that branch? cc @rakita

@mattsse
Copy link
Member

mattsse commented Nov 24, 2023

yep, should be, this would also unblock ssz features that we wanted for some relay rpc-types

@rakita
Copy link
Contributor

rakita commented Nov 24, 2023

I see, is it possible to cherry pick the alloy bump to that branch? cc @rakita

done: bluealloy/revm#875

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending clippy

@DaniPopes DaniPopes marked this pull request as ready for review November 24, 2023 17:46
@DaniPopes DaniPopes merged commit 890bc7a into master Nov 24, 2023
20 checks passed
@DaniPopes DaniPopes deleted the dani/bumps2 branch November 24, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants