Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(debugger): modularize and add a context struct #6495

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Dec 2, 2023

Motivation

  • Clearly split the two event loop phases of the debugger (process & draw) into separate files
  • Create a context to hold the debugger state and use it in processing

No functional changes. Follow-up required to refactor drawing to use the context as well.

Best reviewed commit-by-commit and with "hide whitespace". I've tried my best to keep commit diffs readable.

Solution

@DaniPopes DaniPopes marked this pull request as ready for review December 2, 2023 01:45
@DaniPopes DaniPopes changed the title refactor(debugger): modularize refactor(debugger): modularize and add a context struct Dec 2, 2023
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better

@DaniPopes DaniPopes merged commit d2183da into master Dec 4, 2023
19 checks passed
@DaniPopes DaniPopes deleted the dani/debugger-stuff3 branch December 4, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants