refactor(debugger): use context when drawing #6520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/debugger-stuff4
branch
from
1dd64fc
to
c4338c4
Compare
mattsse
approved these changes
Dec 4, 2023
Evalir
approved these changes
Dec 4, 2023
|
|
||
| /// This is currently used to remember last scroll position so screen doesn't wiggle as much. | ||
| #[derive(Default)] | ||
| pub(crate) struct DrawMemory { | ||
| pub(crate) current_startline: usize, | ||
| // TODO |
There was a problem hiding this comment.
It was the only field that gets modified while drawing, I don't know if removing the mutation breaks the debugger since I have no idea what that code does :D
I'll address in follow-up
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Slowly untangle the draw code. Will require yet another follow-up to clean up the actual implementation to not overload the diff of this PR.
Solution
Implement the draw functions as methods on the context.