fix(cheatcodes): recorded created account during broadcast #6527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the appropriate caller is used to compute the deployed address during a CREATE/CREATE2 operation. As such, during broadcast, the configured wallet address is used rather than the current EVM caller.
Inphi
force-pushed
the
inphi/record-broadcast
branch
from
f077feb
to
27b652e
Compare
Inphi
commented
Dec 5, 2023
| // allow cheatcodes from the address of the new contract | ||
| // Compute the address *after* any possible broadcast updates, so it's based on the updated | ||
| // call inputs | ||
| let address = self.allow_cheatcodes_on_create(data, call); |
There was a problem hiding this comment.
Note that this changes the old, possibly incorrect, behavior. It might not matter, but now wallet deployed accounts are now allowed to executed cheatcodes.
Closed
2 tasks
Evalir
approved these changes
Dec 5, 2023
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Deployed address is incorrect when broadcasting. Fixes #6514.
Solution
The EVM behavior is slightly different when broadcast,
vm.startBroadcast(), is enabled. During broadcast, the deployer address is set to the configured wallet. Previously, the record access cheatcode would always use the current EVM caller to compute the created address. This patch ensures that the appropriate caller is used.