feat(forge): account access cheatcode accounts for extcode* and balance opcodes

[emo-eth]

Motivation

vm.startStateDiffRecording should track the BALANCE and EXTCODE* family of opcodes, since they affect account warmth

Closes #6544

Solution

Adds 4 more values to the AccountAccessKind enum and watches for those 4 opcodes as part of step.

[mattsse]

this looks reasonable.

this mimics the existing opcode handling, tests look good.

pending @Evalir @DaniPopes

[Inphi]

Typically, the AccountAccessKinds indicate an EVM context switch. The Extcode* opcodes breaks this expectation. What do you think about indicating them in the StorageAccess struct? This way, all extcode* accesses are grouped under the current context.

[emo-eth]

Typically, the AccountAccessKinds indicate an EVM context switch. The Extcode* opcodes breaks this expectation. What do you think about indicating them in the StorageAccess struct? This way, all extcode* accesses are grouped under the current context.

How would you modify StorageAccess to accommodate? Could add a new extcode enum to the end and rename it something like StorageOrExtcodeAccess, but imo that just makes the struct more confusing.

[Inphi]

Typically, the AccountAccessKinds indicate an EVM context switch. The Extcode* opcodes breaks this expectation. What do you think about indicating them in the StorageAccess struct? This way, all extcode* accesses are grouped under the current context.

How would you modify StorageAccess to accommodate? Could add a new extcode enum to the end and rename it something like StorageOrExtcodeAccess, but imo that just makes the struct more confusing.

You're right, that would be more confusing. I guess this is fine as-is then. With the Resume access kind, we probably could even flatten both storage and account accesses in a single array. As it's now possible to link contexts.
@JuanCoRo care to chime in, as I think you may have a unique usecase for this cheat code.

[emo-eth]

Update to include balance opcode as well, since that marks the target account as warm. I think that's all of them, for real this time – any I might be missing?

[JuanCoRo]

@Inphi thanks for the ping! This looks good to me, I don't think it will be any trouble for what I'm using it 👌

[DaniPopes]

@emo-eth FYI https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

[DaniPopes]

LGTM