refactor: only use channel to return test results #6550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/test-cleanup
branch
from
07e63a1
to
653c009
Compare
mattsse
approved these changes
Dec 8, 2023
crates/forge/src/multi_runner.rs
Outdated
| /// The same as [`test`](Self::test), but returns the results instead of streaming them. | ||
| /// | ||
| /// Note that returns only when all tests have been executed. | ||
| pub async fn test_map( |
There was a problem hiding this comment.
maybe something like test_collect? or collect_results?
| filter: impl TestFilter, | ||
| stream_result: Option<Sender<(String, SuiteResult)>>, | ||
| filter: &dyn TestFilter, | ||
| stream_result: mpsc::Sender<(String, SuiteResult)>, |
There was a problem hiding this comment.
What I also want to have here (for followups) is dedicated types instead of tuples.
dealing with BtreeMap<String, Suiteresult> is a bit horrible, I think we want a wrapper type so we can add useful helper functions
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Starting to clean up the mess that is test code.
Solution