feat: add rpc endpoint config #6582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mattsse, I am still very new to rust and please correct me if any thing is not right. And where are the places need impl to make this config work? shall I do it in this PR or in another PR? |
mattsse
requested changes
Dec 12, 2023
There was a problem hiding this comment.
this is a great first draft:
left some suggestions:
then we need some parser tests, see for example:
foundry/crates/config/src/lib.rs
Line 3015 in cdbaf9d
once we have that we can start adding new resolve_rpc_config functions
|
hey @qiweiii , happy new year! will you pick this up soon? no worries if not, we can take to completion. |
|
this is almost complete. taking over, thanks @qiweiii 🙏 |
mattsse
approved these changes
Jan 5, 2024
RPate97
pushed a commit
to RPate97/foundry
that referenced
this pull request
Jan 12, 2024
* feat: add rpc endpoint config * wip: add test for parse rpc config * feat: support setting additional rpc values --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
related to #6532
Solution
add RpcEndpointConfig as described in the issue