feat: LogCollector use alloy_primitives::Log #6752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @mattsse, are my changes the expected solution? |
mattsse
requested changes
Jan 10, 2024
mattsse
requested changes
Jan 10, 2024
There was a problem hiding this comment.
this lgtm
pending Default usage and sanity check @DaniPopes
|
Needs rebase to alloy-primitives 0.6.0. |
|
Does this mean I need to update |
|
Yes that would be ideal, since the only fields we're using are data and topics |
|
that sounds reasonable! |
qiweiii
changed the title
DaniPopes
approved these changes
Jan 11, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
resolve: #6746
Solution