-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(anvil
): Add base alloy types
#6778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
reviewed
Jan 12, 2024
Comment on lines
1
to
5
use alloy_consensus::{TxEip2930, TxEip1559, TxLegacy}; | ||
use alloy_network::{TxKind, Signed}; | ||
use alloy_primitives::{Address, B256, Bloom, Bytes, Log, U256}; | ||
use alloy_rlp::{Encodable, Decodable, Header as RlpHeader, Error as DecodeError}; | ||
use alloy_rpc_types::AccessList; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DaniPopes we prob want to figure out a nice re-export for these
Evalir
changed the title
[WIP] chore(
chore(Jan 15, 2024
anvil
): Migrate base typesanvil
): Migrate base types
Evalir
changed the title
chore(
chore(Jan 15, 2024
anvil
): Migrate base typesanvil
): Add base alloy types
mattsse
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits, otherwise lgtm
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an alloy version of the types in
anvil-core
, replacing them withalloy-consensus
types. We keep our ownTypedTransactionRequest
/TypedTransaction
/TypedReceipt
types to enable optimism support.Note that this PR only adds types. It doesn't remove or migrate the old types as to not blow up the scope. Incremental PRs removing old code will follow.