Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop using console2 #6804

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat: stop using console2 #6804

merged 1 commit into from
Jan 15, 2024

Conversation

DaniPopes
Copy link
Member

Motivation

There is no reason to use console2 anymore.

Solution

@onbjerg onbjerg added the T-debt Type: code debt label Jan 15, 2024
@DaniPopes DaniPopes merged commit 24abca6 into master Jan 15, 2024
18 of 19 checks passed
@DaniPopes DaniPopes deleted the dani/drop-console2 branch January 15, 2024 19:50
@DaniPopes
Copy link
Member Author

Further clarification:
console2 was only created because the Hardhat console's (console) incorrect ABI encoding made it so that the calls would not show up / be decoded in traces, as noted in the console2 docs.

Both consoles have the same effect now in Foundry after #6504, so only one console will exist in a future version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-debt Type: code debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants