Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace internal CallKind #6824

Merged
merged 2 commits into from
Jan 16, 2024
Merged

refactor: replace internal CallKind #6824

merged 2 commits into from
Jan 16, 2024

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Jan 16, 2024

Replace CallKind in Foundry with the one from revm-inspectors. Might be worth extracting the type into Alloy, although I'm unsure where it would fit (since it's not used in Alloy at all) to avoid crates depending on revm-inspectors for that type only.

Closes #6725

@onbjerg onbjerg added the T-debt Type: code debt label Jan 16, 2024
@DaniPopes
Copy link
Member

Closes #6725

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less types good

@onbjerg onbjerg merged commit e4de7b7 into master Jan 16, 2024
20 checks passed
@onbjerg onbjerg deleted the onbjerg/rm-callkind branch January 16, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-debt Type: code debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deduplicate CallKind
3 participants