feat(anvil): remove old ethers-dependent anvil core types
#6842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
reviewed
Jan 18, 2024
| @@ -2540,12 +2531,13 @@ pub fn prove_storage( | |||
| .unwrap(); | |||
|
|
|||
| let item: U256 = { | |||
| let decode_value = |bytes: &[u8]| rlp::decode(bytes).expect("decoding db value failed"); | |||
| let decode_value = |mut bytes: &[u8]| { | |||
| <U256 as alloy_rlp::Decodable>::decode(&mut bytes).expect("decoding db value failed") | |||
| @@ -1,225 +0,0 @@ | |||
| use crate::eth::error::BlockchainError; | |||
There was a problem hiding this comment.
@mattsse IIRC this was due to lack of object safety on signer?
DaniPopes
reviewed
Jan 18, 2024
onbjerg
approved these changes
Jan 18, 2024
gakonst
reviewed
Jan 19, 2024
| @@ -33,6 +33,35 @@ pub mod sequence { | |||
| } | |||
| } | |||
|
|
|||
| pub mod numeric { | |||
There was a problem hiding this comment.
Should this be an alloy util? @DaniPopes
Evalir
changed the title
anvil): remove ethers & old ethers-dependent anvil core typesanvil): remove old ethers-dependent anvil core types
Evalir
added a commit
that referenced
this pull request
Jan 25, 2024
* here we go again * wip: storage * chore: migrate executor, fmt * wip * chore: roughly only signers left * feat: migrate proof, bar trie stuff * chore: onto tests * chore: passing most tests * chore: fix impersonate * chore: op tests passing * txenvelope * chore: some fixes, typed data * feat(`anvil`): remove old ethers-dependent anvil core types (#6842) * feat: remove most ethers and old anvil core types * chore: replace handles for providers constructed on actual tests * finish moving test providers * chore: switch to decode_revert * chore: replace with maybe_decode_revert * u256::decode * chore: move all of anvil but tests and block subscriptions off ethers * re-enable opt * solve nits * chore: remove more println * chore: rename to gen * chore: update alloy, cleanup * chore: fix tests * chore: rename to sign * chore: fmt * chore: cleanup * docs * chore: more cleanup * clippy/fmt * chore: remove ethers from anvil-core, rm fastrlp * chore: remove fastrlp from exceptions in deny.toml * chore: rename and cleanup * directly use type to decode * address review comments * feat: onbjerg nits * chore: fix deny check * bump alloy * chore: add to_ethers ext trait for wallets * chore: update deps, revert changed typed-data tests, set chain id as none when signing typed data --------- Co-authored-by: Oliver Nordbjerg <hi@notbjerg.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
removes ethers usage in all of anvil. Only remaining usage is:
test failures will be fixed in another PR on 6808.
Goes into #6808.
Solution