feat(anvil): Core types migration
#6808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
reviewed
Jan 17, 2024
* feat: remove most ethers and old anvil core types * chore: replace handles for providers constructed on actual tests * finish moving test providers * chore: switch to decode_revert * chore: replace with maybe_decode_revert * u256::decode * chore: move all of anvil but tests and block subscriptions off ethers * re-enable opt * solve nits * chore: remove more println * chore: rename to gen
DaniPopes
requested changes
Jan 20, 2024
|
deny check comes from mdbook's |
onbjerg
approved these changes
Jan 23, 2024
mattsse
reviewed
Jan 23, 2024
|
@mattsse I expect no regressions for this PR as the test suite is saying everything's okay, but the rlp/signing issues on alloy make me feel a bit uneasy. I think we should put our attention there and fix upstream before we merge this, just to be careful. |
|
Blocked on alloy-rs/core#499, needs an alloy-rs/alloy followup afterwards with the functionality in the aforementioned PR so we can get the same hashes on typed data as before. |
Evalir
force-pushed
the
evalir/migrate-base-anvil
branch
from
41e9b60
to
07fb76d
Compare
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Migrates Anvil to use alloy. This brings over types from Alloy Primitives, along with custom types which Anvil needs, mainly to support Optimism deposit transactions, and its internal execution logic.
The big diff is mainly concerned with the deletion of a lot of unneeded files.
Only test utilities which are needed on anvil remain on ethers (Related to providers). Followup PRs will remove ethers from anvil tests completely and subsequently remove the ethers dep.
Solution
Move Anvil to use Alloy. A couple of things to note:
{ v: 0, r: 0, s: 0}anymore, as it's not possible to construct such signature with our new Signature type. It's changed to{ v: 1, r: 1, s: 1}.