feat(chisel): add --no-vm option, enabled by default for old Solc versions #6854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
approved these changes
Jan 19, 2024
mds1
reviewed
Jan 19, 2024
DaniPopes
force-pushed
the
dani/chisel-no-vm
branch
from
1a1bd2d
to
fe6a3ac
Compare
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
By default chisel injects the test Vm interface into the default REPL contract, but this doesn't work with older Solc versions because the interface only supports >=0.8.4.
Closes #6850
Solution
Add
--no-vmto disable the Vm injection, toggled by default for unsupported versions.