Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: forge build spinner output #6872

Merged
merged 2 commits into from
Jan 21, 2024
Merged

fix: forge build spinner output #6872

merged 2 commits into from
Jan 21, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jan 21, 2024

smol regression of #6702

the spinner must be dropped so it terminates properly

This fixes additional output introduced by the spinner stdout flush

[⠒] Compiling...
[⠒] Compiling 22 files with 0.8.23
[⠔] Solc 0.8.23 finished in 3.00sCompiler run successful!
[⠒] Solc 0.8.23 finished in 3.00s

Evalir
Evalir approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mattsse mattsse merged commit 5ea2c5e into foundry-rs:master Jan 21, 2024
19 checks passed
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Evalir