feat(evm, forge): use alloy TransactionRequest for saving BroadcastableTransactions
#6876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…broadcastable txs
DaniPopes
approved these changes
Jan 22, 2024
Evalir
force-pushed
the
evalir/use-alloy-request
branch
from
ae18472
to
6390e30
Compare
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We keep broadcastable transactions for scripts in ethers types, but this is completely unnecesary until the point where they'll be processed/sent (filled with gas, simualted and whatnot). This means we can just use an RPC
TransactionRequesttype to save the data before its processed.Solution
Phases out
TypedTransaction/TransactionRequestfrom the evm core crate, and removes a bunch of unnecesary conversions in scripts by result. This containsTypedTransaction/TransactionRequestethers equivalents to only script and cast.