feat(evm): migrate to alloy-genesis, rm ethers-core
#6880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jan 22, 2024
|
failing tests look related |
|
Yeah tests are failing because it seems storage is not being set properly—need to take a look |
|
bump here |
mattsse
requested changes
Jan 24, 2024
|
@mattsse for the issue, see: alloy-rs/alloy#151 (comment) |
|
thanks, now this makes sense to me 🙏 |
mattsse
approved these changes
Jan 24, 2024
DaniPopes
reviewed
Jan 24, 2024
DaniPopes
approved these changes
Jan 24, 2024
Evalir
force-pushed
the
evalir/mig-genesis
branch
from
76acd42
to
1a4789a
Compare
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Migrates to using alloy genesis instead of ethers core types for genesis utils.
Solution
Removes ethers core, migrates to alloy genesis.
The
loadAllocscheatcode was modified to try reading from a json file which only contains allocs, if the allocs read from the genesis file is empty. This is because nowGenesiscan be deserialized as default, and will not fail if theallocfield is missing.