fix: fix off by one debugger draw #6886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great job! it works in my case. The right is the fixed version of forge i ran with: forge run contracts/debug_helper.sol --debug And i can keep scrolling down the binary code line by line until the contract revert.
|
onbjerg
approved these changes
Jan 23, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimistically closes #6878
see #6878 (comment)
this should fix an off by one here:
https://github.com/foundry-rs/foundry/blob/master/crates/debugger/src/tui/draw.rs#L281-L281
but tbh I don't know for sure without a repro, perhaps @ethever can try?
FYI @brockelmore